Skip to main content

Conversion to std::string and return from function

 Many times I have come across code something like the below:

class AClass {

public:

    std::string getName();

};

std::string AClass::getName() {

    return "I am returning";

}

Here the member function converts the string constant to std::string while returning. This is in my opinion not necessary. This cast away some flexibility. I mean this way of converting to a std::string while returning to function does not make much sense. 

Reason: 

If we need in any place to get the name as const char* I need to reverse by calling string::c_str()

const char* pName = instanceOfClassA.getName().c_str();

However, keeping the return type as const char* has some benefits:

const char* AClass::getName() const {

    return "I am returning";

}

1. const char* pName =  instanceOfClassA.getName().getName(); // No Conversion will take place

2. std::string sName = instanceOfClassA.getName().getName(); // Conversion happens to std::string 

So, only based on usage conversion happens. It delays conversion until needed.

Now arguably, we can say that why not use c_str() to get something as const char*. I mean, let the function remain as below: 

std::string AClass::getName() {

    return "I am returning";

}

The usage may be like this:

const char* pName = instanceOfClassA.getName().c_str(); 

/*Other use of pName.... */

c_str() will return [internal buffer (C++ 11) of std::string as] const char*. But it's not reliable.

Why? The explanation is given in the link


In a line, to simplify it, we can't use data pointed by c_str() past the lifetime of std::string object or changed by a function. In both of those cases, the pointer will be invalidated. 

Comments

Post a Comment

Popular posts from this blog

Reversing char array without splitting the array to tokens

 I was reading about strdup, a C++ function and suddenly an idea came to my mind if this can be leveraged to aid in reversing a character array without splitting the array into words and reconstructing it again by placing spaces and removing trailing spaces. Again, I wanted an array to be passed as a function argument and an array size to be passed implicitly with the array to the function. Assumed, a well-formed char array has been passed into the function. No malformed array checking is done inside the function. So, the function signature and definition are like below: Below is the call from the client code to reverse the array without splitting tokens and reconstructing it. Finally, copy the reversed array to the destination.  For GNU C++, we should use strdup instead _strdup . On run, we get the following output: Demo code
Post a Comment
Read more

A simple approach to generate Fibonacci series via multi-threading

T his is a very simple approach taken to generate the Fibonacci series through multithreading. Here instead of a function, used a function object. The code is very simple and self-explanatory.  #include <iostream> #include <mutex> #include <thread> class Fib { public:     Fib() : _num0(1), _num1(1) {}     unsigned long operator()(); private:     unsigned long _num0, _num1;     std::mutex mu; }; unsigned long Fib::operator()() {     mu.lock(); // critical section, exclusive access to the below code by locking the mutex     unsigned long  temp = _num0;     _num0 = _num1;     _num1 = temp + _num0;     mu.unlock();     return temp; } int main() {     Fib f;          int i = 0;     unsigned long res = 0, res2= 0, res3 = 0;     std::cout << "Fibonacci series: ";     while (i <= 15) {         std::thread t1([&] { res = f(); }); // Capturing result to respective variable via lambda         std::thread t2([&] { res2 = f(); });         std::thread t3(
Post a Comment
Read more

Close a Window Application from another application.

 This is just a demo application code to show how the WM_CLOSE message can be sent to the target process which has a titled window to close the application. To achieve this, either we can use SendMessage or PostMessage APIs to send required Windows messages to the target application. Though both the APIs are dispatching WM_XXXXX message to target application two APIs has some differences, these are as below: 1. SendMessage () call is a blocking call but PostMessage is a non-blocking call(Asynchronous) 2. SendMessage() APIs return type is LRESULT (LONG_PTR) but PostMessage() APIs return type is BOOL(typedef int). In Short, SendMessage () APIs return type depends on what message has been sent to the Windowed target process. For the other one, it's always a non-zero value, which indicates the message has been successfully placed on the target process message queue. Now let's see how can I close a target windowed application "Solitaire & Casual Games" from my custom-
Post a Comment
Read more